Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hint of specify_shape does not allow for None in shape #1313

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

sudarsan2k5
Copy link
Contributor

fixes #1164
Updated specify_shape type hint , allowed None in shape

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

@rlouf
Copy link
Member

rlouf commented Nov 24, 2022

Thank you for opening a PR. It looks like you need to format your code using pre-commit.

@brandonwillard brandonwillard added the typing Work related to type checking label Nov 25, 2022
brandonwillard
brandonwillard previously approved these changes Nov 25, 2022
Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just updated the formatting; this should be good to merge now. Thanks @sudarsan2k5!

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #1313 (dff0aca) into main (a7ef6db) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1313   +/-   ##
=======================================
  Coverage   74.22%   74.22%           
=======================================
  Files         174      174           
  Lines       48731    48732    +1     
  Branches    10367    10367           
=======================================
+ Hits        36170    36171    +1     
  Misses      10273    10273           
  Partials     2288     2288           
Impacted Files Coverage Δ
aesara/tensor/shape.py 91.74% <100.00%> (+0.01%) ⬆️

@rlouf rlouf merged commit c34be65 into aesara-devs:main Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing Work related to type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type hint of specify_shape does not allow for None in shape
3 participants