Fix bug on macOS from pickling a closure #1315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1315 +/- ##
=======================================
Coverage 74.75% 74.75%
=======================================
Files 194 194
Lines 49899 49899
Branches 10554 10554
=======================================
Hits 37303 37303
Misses 10269 10269
Partials 2327 2327 |
dgerlanc
force-pushed
the
fix_test_cache_race_condition
branch
from
78339bb
to
fdf5a4c
Compare
dgerlanc
force-pushed
the
fix_test_cache_race_condition
branch
from
fdf5a4c
to
aae5979
Compare
- Fix serialization/pickling error by moving `f_build` out of `test_cache_race_condition` and to module scope. - Add conditional to check for macOS on Python versions < 3.8 and use "spawn" instead of fork to launch processes - Reduce number of forked processes to 2 - Reduce number of loop iterations to 2 - Use constant scaling factor instead of random factors Resolves: aesara-devs#1314
dgerlanc
force-pushed
the
fix_test_cache_race_condition
branch
from
aae5979
to
3eb3375
Compare
|
Resolved by #1452 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1314