-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Numba dispatching and interfaces #1317
Merged
brandonwillard
merged 6 commits into
aesara-devs:main
from
brandonwillard:Numba-objmode-fallbacks
Dec 1, 2022
Merged
Refactor Numba dispatching and interfaces #1317
brandonwillard
merged 6 commits into
aesara-devs:main
from
brandonwillard:Numba-objmode-fallbacks
Dec 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
Numba-objmode-fallbacks
branch
from
November 29, 2022 06:48
41d2464
to
adef30f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1317 +/- ##
==========================================
+ Coverage 74.10% 74.22% +0.12%
==========================================
Files 174 174
Lines 48673 48754 +81
Branches 10373 10367 -6
==========================================
+ Hits 36067 36190 +123
+ Misses 10315 10275 -40
+ Partials 2291 2289 -2
|
brandonwillard
force-pushed
the
Numba-objmode-fallbacks
branch
2 times, most recently
from
December 1, 2022 00:20
ab0a363
to
0d0643e
Compare
brandonwillard
force-pushed
the
Numba-objmode-fallbacks
branch
from
December 1, 2022 00:24
0d0643e
to
ab29d05
Compare
brandonwillard
force-pushed
the
Numba-objmode-fallbacks
branch
from
December 1, 2022 18:08
ab29d05
to
43304c8
Compare
brandonwillard
changed the title
Fall back to object-mode on
Refactor Numba dispatching and interfaces
Dec 1, 2022
TypingError
s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies some of the dispatch interfaces for the Numba transpilation code, by—for instance—making it possible to customize Numba signature construction based on Aesara
Type
s. It also introduces some necessary updates for the use of more recent Numba versions.