Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Numba dispatching and interfaces #1317

Merged

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Nov 29, 2022

This PR clarifies some of the dispatch interfaces for the Numba transpilation code, by—for instance—making it possible to customize Numba signature construction based on Aesara Types. It also introduces some necessary updates for the use of more recent Numba versions.

@brandonwillard brandonwillard marked this pull request as draft November 29, 2022 06:47
@brandonwillard brandonwillard added important Numba Involves Numba transpilation labels Nov 29, 2022
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1317 (43304c8) into main (14c394d) will increase coverage by 0.12%.
The diff coverage is 93.31%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
+ Coverage   74.10%   74.22%   +0.12%     
==========================================
  Files         174      174              
  Lines       48673    48754      +81     
  Branches    10373    10367       -6     
==========================================
+ Hits        36067    36190     +123     
+ Misses      10315    10275      -40     
+ Partials     2291     2289       -2     
Impacted Files Coverage Δ
aesara/link/jax/dispatch/basic.py 83.87% <ø> (ø)
aesara/link/jax/dispatch/scalar.py 97.40% <ø> (ø)
aesara/misc/check_blas.py 0.00% <0.00%> (ø)
aesara/misc/elemwise_time_test.py 0.00% <0.00%> (ø)
aesara/misc/latence_gpu_transfert.py 0.00% <0.00%> (ø)
aesara/compile/function/types.py 79.16% <75.00%> (+0.16%) ⬆️
aesara/link/c/cmodule.py 52.04% <77.77%> (ø)
aesara/tensor/slinalg.py 92.59% <81.15%> (+8.18%) ⬆️
aesara/tensor/elemwise.py 88.07% <90.54%> (-0.52%) ⬇️
aesara/graph/rewriting/basic.py 65.03% <92.30%> (ø)
... and 34 more

@brandonwillard brandonwillard force-pushed the Numba-objmode-fallbacks branch 2 times, most recently from ab0a363 to 0d0643e Compare December 1, 2022 00:20
@brandonwillard brandonwillard changed the title Fall back to object-mode on TypingErrors Refactor Numba dispatching and interfaces Dec 1, 2022
@brandonwillard brandonwillard marked this pull request as ready for review December 1, 2022 18:51
@brandonwillard brandonwillard added the refactor This issue involves refactoring label Dec 1, 2022
@brandonwillard brandonwillard merged commit e8c042b into aesara-devs:main Dec 1, 2022
@brandonwillard brandonwillard deleted the Numba-objmode-fallbacks branch December 1, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Numba Involves Numba transpilation refactor This issue involves refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant