Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for SciPy CSC and CSR sparse types in Numba #1336

Merged

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Dec 6, 2022

This PR adds support for SciPy sparse matrix types to Numba. Currently, only boxing and unboxing of CSC and CSR types are supported.

This is the start of #658.

  • Finish the boxing implementation

@brandonwillard brandonwillard self-assigned this Dec 6, 2022
@brandonwillard brandonwillard marked this pull request as draft December 6, 2022 01:47
@brandonwillard brandonwillard added enhancement New feature or request Numba Involves Numba transpilation important labels Dec 6, 2022
@brandonwillard brandonwillard marked this pull request as ready for review December 6, 2022 18:39
@brandonwillard brandonwillard changed the title Add basic support for SciPy sparse types in Numba Add basic support for SciPy CSC and CSR sparse types in Numba Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #1336 (4dfd74d) into main (e8c042b) will increase coverage by 0.04%.
The diff coverage is 96.77%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1336      +/-   ##
==========================================
+ Coverage   74.22%   74.27%   +0.04%     
==========================================
  Files         174      175       +1     
  Lines       48754    48841      +87     
  Branches    10367    10369       +2     
==========================================
+ Hits        36190    36276      +86     
- Misses      10275    10276       +1     
  Partials     2289     2289              
Impacted Files Coverage Δ
aesara/link/numba/dispatch/basic.py 92.30% <0.00%> (-0.20%) ⬇️
aesara/scan/op.py 85.13% <60.00%> (ø)
aesara/link/numba/dispatch/__init__.py 100.00% <100.00%> (ø)
aesara/link/numba/dispatch/sparse.py 100.00% <100.00%> (ø)
aesara/link/vm.py 92.55% <100.00%> (ø)

@brandonwillard brandonwillard merged commit 75f09bf into aesara-devs:main Dec 7, 2022
@brandonwillard brandonwillard deleted the add-numba-sparse-types branch December 7, 2022 01:16
@brandonwillard
Copy link
Member Author

@aesara-devs/core I merged this to see whether or not some typing updates in this PR would get rid of #1221. I'll create a follow-up to this shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request important Numba Involves Numba transpilation sparse tensors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant