Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support read-only Numba types #1343

Merged

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Dec 9, 2022

This PR adds support for read-only types via our loosely established Variable.tag.indestructible flag.

This PR also closes #1221 by simply ignoring those errors and disabling warn_unused_ignores for that specific module.

@brandonwillard brandonwillard added bug Something isn't working Numba Involves Numba transpilation labels Dec 9, 2022
@brandonwillard brandonwillard self-assigned this Dec 9, 2022
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #1343 (53b6c18) into main (5dee3c7) will increase coverage by 0.00%.
The diff coverage is 94.73%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1343   +/-   ##
=======================================
  Coverage   74.27%   74.27%           
=======================================
  Files         175      175           
  Lines       48886    48887    +1     
  Branches    10375    10375           
=======================================
+ Hits        36311    36312    +1     
  Misses      10282    10282           
  Partials     2293     2293           
Impacted Files Coverage Δ
aesara/link/numba/dispatch/basic.py 92.25% <90.00%> (+0.01%) ⬆️
aesara/link/numba/dispatch/extra_ops.py 98.00% <100.00%> (ø)
aesara/link/numba/dispatch/nlinalg.py 100.00% <100.00%> (ø)
aesara/link/numba/dispatch/sparse.py 92.53% <100.00%> (ø)
aesara/scan/op.py 85.13% <100.00%> (ø)

@brandonwillard brandonwillard merged commit ae182f0 into aesara-devs:main Dec 9, 2022
@brandonwillard brandonwillard deleted the support-numba-readonly-types branch December 9, 2022 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Numba Involves Numba transpilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mypy cannot determine type of op_debug_information
1 participant