Add JAX implementation for LogNormalRV
#1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanitorduz
commented
Dec 9, 2022
| [ | ||
| set_test_value( | ||
| at.lvector(), | ||
| np.array([0, 0], dtype=np.int64), |
There was a problem hiding this comment.
Seem scipy's implementation does not accept a loc param ? https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.lognorm.html
There was a problem hiding this comment.
It seems to work with something like scipy.stats.lognorm(1, loc=10).rvs().
brandonwillard
added
JAX
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1346 +/- ##
=======================================
Coverage 74.35% 74.36%
=======================================
Files 177 177
Lines 49036 49046 +10
Branches 10379 10379
=======================================
+ Hits 36461 36471 +10
Misses 10283 10283
Partials 2292 2292
|
brandonwillard
approved these changes
Dec 9, 2022
brandonwillard
approved these changes
Dec 9, 2022
rlouf
approved these changes
Dec 10, 2022
|
Thank you for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1325
References: