Add ChiSquareRV JAX implementation
#1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
enhancement
|
Looks good, waiting for #1345 to be merged to update the key splitting mechanism. |
rlouf
force-pushed
the
chisq-jax
branch
5 times, most recently
from
870e1c3
to
b03a578
Compare
brandonwillard
force-pushed
the
chisq-jax
branch
from
d350b0a
to
fa67754
Compare
rlouf
previously approved these changes
Feb 21, 2023
|
Thanks for your contribution @larryshamalama! |
|
I am unable to reproduce the test failure locally (it even works with smaller a smaller number of samples). We need to understand what causes this. |
rlouf
force-pushed
the
chisq-jax
branch
2 times, most recently
from
a4356c1
to
27f09c4
Compare
|
I can have a look later, but I'm currently on vacation until early March so I will only be able to do so then. Admittedly, I have not looked much into this PR after its inception... |
|
I don't think the failures have anything to do with your implementation; the tests pass locally for me. |
brandonwillard
force-pushed
the
chisq-jax
branch
from
27f09c4
to
654baac
Compare
brandonwillard
force-pushed
the
chisq-jax
branch
2 times, most recently
from
04aca2e
to
be7e3ea
Compare
brandonwillard
force-pushed
the
chisq-jax
branch
from
be7e3ea
to
bf58a94
Compare
brandonwillard
force-pushed
the
chisq-jax
branch
from
bf58a94
to
6f9cda7
Compare
|
Thanks, @larryshamalama! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1322
Given the shape/rate parametrization of$$\chi^2_{\text{df}} \equiv \Gamma\left(\frac{\text{df}}{2}, \frac{1}{2} \right).$$
GammaRVin Aesara, this addition uses the fact thatWiki reference here