Add random alias to aesara.tensor.random.basic
#1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1364 +/- ##
=======================================
Coverage 74.66% 74.66%
=======================================
Files 177 177
Lines 49050 49051 +1
Branches 10400 10400
=======================================
+ Hits 36623 36624 +1
Misses 10131 10131
Partials 2296 2296
|
brandonwillard
added
enhancement
brandonwillard
force-pushed
the
fix_1353
branch
2 times, most recently
from
c977fed
to
f4fc6c0
Compare
brandonwillard
changed the title
RandomRVrandom alias to aesara.tensor.random.basic
brandonwillard
previously approved these changes
Dec 15, 2022
|
The current error looks like it might be due to recent changes in JAX. |
Yes. Pushed a fix in #1372 |
rlouf
approved these changes
Dec 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1353
This PR will add random() function in RandomStream.
For the testsuite I just copy that as standard_normal() does, look for some feedback.