Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HalfCauchyRV JAX implementation #1370

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

theorashid
Copy link
Contributor

This is for #1334. Hopefully it's as obvious as the halfnormal


Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

@theorashid theorashid changed the title Add HalfNormalRV JAX implementation #1365 Add HalfNormalRV JAX implementation Dec 14, 2022
@rlouf rlouf changed the title Add HalfNormalRV JAX implementation Add HalfCauchyRV JAX implementation Dec 14, 2022
@rlouf rlouf linked an issue Dec 14, 2022 that may be closed by this pull request
@theorashid
Copy link
Contributor Author

Also, n00b git question. What the correct git for rebasing and changing the commit name? I f'd it up a bit last time. I just ran git fetch upstream
git rebase upstream/main

@rlouf
Copy link
Member

rlouf commented Dec 14, 2022

To pull from upstream and rebase git pull --rebase upstream.

To rename a commit git rebase -i. The git doc is pretty good if you need more details.

@theorashid
Copy link
Contributor Author

theorashid commented Dec 14, 2022

Well I did the rebase but I made a mess again lol. I'll have a look after the football. Don't merge yet and I'll let you know if I can't fix it

@rlouf
Copy link
Member

rlouf commented Dec 14, 2022

Don't hesitate to ask for help!

@theorashid
Copy link
Contributor Author

Hey, yeah I'm not sure how to do this unfortunately. I can only seem to amend the 14 rebase commits rather than the 2 I added. And there's no option to squash. Please let me know how you fix this and I'll never ask again next time I contribute

Also, the workflows are failing but that isn't to do with me by the looks of it. My tests pass locally

@brandonwillard brandonwillard added enhancement New feature or request JAX Involves JAX transpilation labels Dec 14, 2022
Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theorashid, I dropped the merge commit (well, all the commits added by the merge commit), squared the typo fix commit into the original feature commit, and rebased the resulting single commit onto upstream/main. The last step should not introduce any new commits. You can use the command-line interactive rebasing to do the same thing locally; otherwise, you can pull in the changes from your remote branch by rebasing and ignoring any local conflicts.

@theorashid
Copy link
Contributor Author

theorashid commented Dec 15, 2022

Great, thank you. This should be good to go. btw I'm used to repos which squash all commits before merging for pull requests

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #1370 (1bd931f) into main (67ea5b6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1370   +/-   ##
=======================================
  Coverage   74.66%   74.66%           
=======================================
  Files         177      177           
  Lines       49050    49060   +10     
  Branches    10400    10400           
=======================================
+ Hits        36623    36633   +10     
  Misses      10131    10131           
  Partials     2296     2296           
Impacted Files Coverage Δ
aesara/link/jax/dispatch/random.py 100.00% <100.00%> (ø)

@rlouf
Copy link
Member

rlouf commented Dec 15, 2022

It is only one commit now. Thanks for your contribution!

@rlouf rlouf merged commit 3418496 into aesara-devs:main Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request JAX Involves JAX transpilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JAX implementation for HalfCauchyRV
3 participants