Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade flake8 pre-commit for py37 compatibility #1374

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Dec 15, 2022

Closes #1373

Aesara's minimum-supported Python version is 3.7, and it's probably really convenient to develop with that version in order to avoid using incompatible language features. Then of course you want to run pre-commit, but for that you either need a higher version of Python (>=3.8.1) or a lower (<=5.0.4) version of flake8.

It seems to me like the most straightforward solution is to revert flake8 to 5.0.4 (the second-most-recent release, August) until Aesara drops support for Python 3.7.

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

brandonwillard
brandonwillard previously approved these changes Dec 15, 2022
Aesara's minimum-supported Python version is 3.7, and it's probably
really convenient to develop with that version in order to avoid using
incompatible language features. Then of course you want to run
pre-commit, but for that you either need a higher version of Python
(>=3.8.1) or a lower (<=5.0.4) version of flake8.

It seems to me like the most straightforward solution is to revert
flake8 to 5.0.4 (the second-most-recent release, August) until
Aesara drops support for Python 3.7.
@maresb
Copy link
Contributor Author

maresb commented Dec 15, 2022

Rebased on main

@maresb
Copy link
Contributor Author

maresb commented Dec 15, 2022

I have approval, passing checks, and the big green "Rebase and merge" button. Does that mean I'm allowed to push it? 😄

@brandonwillard
Copy link
Member

I have approval, passing checks, and the big green "Rebase and merge" button. Does that mean I'm allowed to push it? smile

Yes, of course.

@maresb maresb merged commit e9bd026 into aesara-devs:main Dec 15, 2022
@maresb maresb deleted the fix-flake8-pre-commit branch December 15, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid pinning a particular python executable in flake8 hook
2 participants