Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set nightly build project.name in pyproject.toml #1380

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Dec 31, 2022

Closes #1379

It seems that python -m build . ignores the project name from the setuptools.setup function when running setup.py. This commit moves the dynamic project name from setup.py to the nightly.yml workflow, using the dasel command-line tool to modify project.name in pyproject.toml.

I also add a workflow_dispatch trigger to nightly.yml for testing.

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

Closes aesara-devs#1379
It seems that python -m build . ignores the project name from the
setuptools.setup function when running setup.py. This commit moves
the dynamic project name from setup.py to the nightly.yml workflow,
using the dasel command-line tool to modify project.name in
pyproject.toml.

I also add a workflow_dispatch trigger to nightly.yml for testing.
@maresb maresb changed the title Update project.name to aesara-nightly with dasel Set nightly build project.name in pyproject.toml Dec 31, 2022
@maresb maresb marked this pull request as ready for review December 31, 2022 12:12
@codecov
Copy link

codecov bot commented Dec 31, 2022

Codecov Report

Merging #1380 (5d798c0) into main (baa6b7f) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1380   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files         195      195           
  Lines       49748    49748           
  Branches    10529    10529           
=======================================
  Hits        37157    37157           
  Misses      10266    10266           
  Partials     2325     2325           

@brandonwillard brandonwillard added bug Something isn't working CI Involves continuous integration labels Dec 31, 2022
@brandonwillard brandonwillard merged commit 0b6b8df into aesara-devs:main Dec 31, 2022
@maresb maresb deleted the fix-nightly branch December 31, 2022 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Involves continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing nightly build
2 participants