-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move aesara-cache into aesara.bin package #1382
Move aesara-cache into aesara.bin package #1382
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
- Coverage 74.69% 74.59% -0.10%
==========================================
Files 195 196 +1
Lines 49748 49813 +65
Branches 10529 10547 +18
==========================================
Hits 37157 37157
- Misses 10266 10331 +65
Partials 2325 2325
|
Maybe there should be test coverage for |
Yeah, we (and Theano) badly need that. |
I thought Aesara officially took over Theano. |
Yes; I'm just saying that I don't recall inheriting such tests from Theano. |
1cd40bd
to
bb969ee
Compare
bb969ee
to
4b9b10d
Compare
Because I don't know why it's being tested, it should be ignored!
4b9b10d
to
4777151
Compare
Oh, nice! I'm glad it merged. Do you understand what went wrong earlier with the coverage check? (It was failing on |
Oh, probably I should have added it to |
As observed in #1375 (comment),
In order to hopefully avoid breaking existing stuff, the old scripts are still there, but now with deprecation warnings.
Thank you for opening a PR!
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.
If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.