Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a CI error message when lazylinker_c.c missing #1383

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Jan 2, 2023

Without this, when lazylinker_c.c is missing, the CI suddenly errors without any message.

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

@maresb maresb added the CI Involves continuous integration label Jan 2, 2023
@maresb maresb marked this pull request as ready for review January 2, 2023 23:12
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1383 (6da16f4) into main (0b6b8df) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1383   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files         195      195           
  Lines       49748    49748           
  Branches    10529    10529           
=======================================
  Hits        37157    37157           
  Misses      10266    10266           
  Partials     2325     2325           

@brandonwillard brandonwillard added the enhancement New feature or request label Jan 3, 2023
@maresb maresb merged commit b6a780b into aesara-devs:main Jan 3, 2023
@maresb maresb deleted the ci-add-error-msg branch January 3, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Involves continuous integration enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants