Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed benchmark tests #1391

Merged

Conversation

brandonwillard
Copy link
Member

This PR sets seeds for data generated in the newly added benchmark tests.

@brandonwillard brandonwillard self-assigned this Jan 7, 2023
@brandonwillard brandonwillard enabled auto-merge (rebase) January 7, 2023 00:32
@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #1391 (0df0b08) into main (d84cc42) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1391   +/-   ##
=======================================
  Coverage   74.69%   74.69%           
=======================================
  Files         195      195           
  Lines       49748    49748           
  Branches    10529    10529           
=======================================
  Hits        37157    37157           
  Misses      10266    10266           
  Partials     2325     2325           
Impacted Files Coverage Δ
aesara/sparse/basic.py 82.53% <100.00%> (ø)

@brandonwillard brandonwillard merged commit 0f8d849 into aesara-devs:main Jan 7, 2023
@brandonwillard brandonwillard deleted the seed-benchmark-tests branch January 7, 2023 01:36
@maresb
Copy link
Contributor

maresb commented Jan 9, 2023

Is the seed expected to significantly affect running times? In other words, is the path of execution (significantly) dependent on the seed, e.g. with stopping criteria?

@brandonwillard
Copy link
Member Author

Is the seed expected to significantly affect running times? In other words, is the path of execution (significantly) dependent on the seed, e.g. with stopping criteria?

Yes, the generated matrices should affect the performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants