Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt dev-builds settings for hatch-vcs #1407

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Feb 5, 2023

When switching from setuptools to Hatch, we switched from setuptools_scm to Hatch's "hatch-vcs" wrapper of setuptools_scm. The keys for passing raw options to setuptools_scm need to be adapted accordingly in the pyproject.toml.

Closes #1406

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

When switching from setuptools to Hatch, we switched from
setuptools_scm to Hatch's "hatch-vcs" wrapper of setuptools_scm.
The keys for passing raw options to setuptools_scm need to be
adapted accordingly in the `pyproject.toml`.

Closes aesara-devs#1406
@maresb maresb mentioned this pull request Feb 5, 2023
6 tasks
@codecov
Copy link

codecov bot commented Feb 5, 2023

Codecov Report

Merging #1407 (8b792d1) into main (e518463) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1407   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files         194      194           
  Lines       49847    49847           
  Branches    10544    10544           
=======================================
  Hits        37243    37243           
  Misses      10274    10274           
  Partials     2330     2330           

@brandonwillard brandonwillard merged commit b5e9b62 into aesara-devs:main Feb 5, 2023
@brandonwillard brandonwillard added the setup and installation Relates to the setup and installation of Aesara label Feb 5, 2023
@maresb maresb deleted the fix-dev-builds branch February 6, 2023 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
setup and installation Relates to the setup and installation of Aesara
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly version numbering issue after package metadata changes
2 participants