Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RayleighRV #1433

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Implement RayleighRV #1433

merged 2 commits into from
Feb 14, 2023

Conversation

Smit-create
Copy link
Member

Fixes #1351

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #1433 (86b6db8) into main (4961799) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1433   +/-   ##
=======================================
  Coverage   74.72%   74.72%           
=======================================
  Files         194      194           
  Lines       49868    49877    +9     
  Branches    10549    10549           
=======================================
+ Hits        37264    37273    +9     
  Misses      10274    10274           
  Partials     2330     2330           
Impacted Files Coverage Δ
aesara/tensor/random/basic.py 99.05% <100.00%> (+0.01%) ⬆️

@rlouf
Copy link
Member

rlouf commented Feb 14, 2023

FYI we don't use TST: or other prefixes in the library. Other than that looks good to me!

@Smit-create Smit-create marked this pull request as ready for review February 14, 2023 15:53
@brandonwillard brandonwillard added enhancement New feature or request random variables Involves random variables and/or sampling Op implementation Involves the implementation of an Op labels Feb 14, 2023
Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thanks again, @Smit-create!

@brandonwillard brandonwillard merged commit 2f9a9e6 into aesara-devs:main Feb 14, 2023
@Smit-create Smit-create deleted the i-1351 branch February 14, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Op implementation Involves the implementation of an Op random variables Involves random variables and/or sampling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Rayleigh RandomVariable
3 participants