Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jax WaldRV (invgauss) #1435

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

FredericWantiez
Copy link
Contributor

This adds a Jax implementation of WaldRV to close #1329. I've added a cdf test but for scipy invgauss means lam=1 (here), I should probably add a few more

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1435 (059fe55) into main (2f9a9e6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 059fe55 differs from pull request most recent head a3dc641. Consider uploading reports for the commit a3dc641 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
+ Coverage   74.72%   74.75%   +0.02%     
==========================================
  Files         194      194              
  Lines       49877    49912      +35     
  Branches    10549    10553       +4     
==========================================
+ Hits        37273    37314      +41     
+ Misses      10274    10270       -4     
+ Partials     2330     2328       -2     
Impacted Files Coverage Δ
aesara/link/jax/dispatch/random.py 100.00% <100.00%> (ø)
aesara/scalar/__init__.py 100.00% <0.00%> (ø)
aesara/scalar/basic.py 79.16% <0.00%> (+0.12%) ⬆️
aesara/tensor/math.py 90.68% <0.00%> (+0.26%) ⬆️
aesara/tensor/__init__.py 96.29% <0.00%> (+0.74%) ⬆️

@brandonwillard brandonwillard added the JAX Involves JAX transpilation label Feb 17, 2023
Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just recommended some updates to the docstring; otherwise, looks good! Many thanks, @FredericWantiez!

aesara/link/jax/dispatch/random.py Outdated Show resolved Hide resolved
Co-authored-by: Brandon T. Willard <971601+brandonwillard@users.noreply.github.com>
@rlouf rlouf merged commit 11c532d into aesara-devs:main Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JAX Involves JAX transpilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add JAX implementation for WaldRV
3 participants