-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace sqr
with square
#1439
Replace sqr
with square
#1439
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
==========================================
- Coverage 74.86% 74.75% -0.12%
==========================================
Files 194 194
Lines 50107 49898 -209
Branches 12098 10554 -1544
==========================================
- Hits 37514 37302 -212
- Misses 10266 10269 +3
Partials 2327 2327
|
Although this can be changed in a separate PR, we should also keep in mind the change suggested in #1213. |
273680a
to
771b44d
Compare
Looks like this has some merge conflicts that need to be resolved now. |
771b44d
to
e3c340d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased and added some missing aesara.tensor
import tests. This should be good to merge once it passes the tests.
Fixes #1422
sqr
forsquare
sqr
Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.