Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sqr with square #1439

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

sudarsan2k5
Copy link
Contributor

Fixes #1422

  • Rename sqr for square
  • Deprecated sqr
  • Added test for deprecation

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

@purna135 purna135 added enhancement New feature or request NumPy compatibility labels Feb 18, 2023
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #1439 (273680a) into main (c433071) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

❗ Current head 273680a differs from pull request most recent head e3c340d. Consider uploading reports for the commit e3c340d to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
- Coverage   74.86%   74.75%   -0.12%     
==========================================
  Files         194      194              
  Lines       50107    49898     -209     
  Branches    12098    10554    -1544     
==========================================
- Hits        37514    37302     -212     
- Misses      10266    10269       +3     
  Partials     2327     2327              
Impacted Files Coverage Δ
aesara/gradient.py 77.02% <ø> (ø)
aesara/scalar/basic.py 79.16% <100.00%> (-0.02%) ⬇️
aesara/sparse/basic.py 82.53% <100.00%> (-0.01%) ⬇️
aesara/tensor/math.py 90.67% <100.00%> (-0.01%) ⬇️
aesara/tensor/rewriting/math.py 85.95% <100.00%> (-0.17%) ⬇️

... and 37 files with indirect coverage changes

@rlouf
Copy link
Member

rlouf commented Feb 19, 2023

Although this can be changed in a separate PR, we should also keep in mind the change suggested in #1213.

@brandonwillard brandonwillard changed the title Replace sqr for square Replace sqr with square Mar 8, 2023
@brandonwillard
Copy link
Member

Looks like this has some merge conflicts that need to be resolved now.

Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've rebased and added some missing aesara.tensor import tests. This should be good to merge once it passes the tests.

@brandonwillard brandonwillard enabled auto-merge (rebase) March 9, 2023 23:28
@brandonwillard brandonwillard merged commit 04ea7d9 into aesara-devs:main Mar 10, 2023
@sudarsan2k5 sudarsan2k5 deleted the rename_sub branch April 26, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace sqr for square
5 participants