Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SharedVariable.default_updates in OpFromGraph #1441

Merged

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Feb 18, 2023

This PR adds support for SharedVariable.default_updates in OpFromGraph, and some miscellaneous fixes to issues discovered along the way.

These changes also provide a means of implementing general support for updates in OpFromGraph (i.e. #1316).

@brandonwillard brandonwillard self-assigned this Feb 18, 2023
@brandonwillard brandonwillard added bug Something isn't working enhancement New feature or request important labels Feb 18, 2023
@brandonwillard brandonwillard enabled auto-merge (rebase) February 19, 2023 00:58
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #1441 (375050a) into main (ead2c02) will increase coverage by 0.05%.
The diff coverage is 95.93%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
+ Coverage   74.75%   74.80%   +0.05%     
==========================================
  Files         194      194              
  Lines       49896    49978      +82     
  Branches    10553    10572      +19     
==========================================
+ Hits        37298    37385      +87     
+ Misses      10270    10267       -3     
+ Partials     2328     2326       -2     
Impacted Files Coverage Δ
aesara/tensor/rewriting/math.py 86.10% <87.50%> (+0.15%) ⬆️
aesara/compile/function/types.py 79.60% <90.47%> (+0.43%) ⬆️
aesara/graph/fg.py 88.91% <95.45%> (+0.38%) ⬆️
aesara/compile/builders.py 79.16% <100.00%> (+2.10%) ⬆️
aesara/compile/ops.py 84.45% <100.00%> (+0.77%) ⬆️
aesara/link/c/cmodule.py 52.32% <100.00%> (+0.27%) ⬆️
aesara/scan/op.py 85.14% <100.00%> (+0.01%) ⬆️
aesara/tensor/__init__.py 96.29% <100.00%> (ø)
aesara/tensor/math.py 90.68% <100.00%> (ø)

@brandonwillard brandonwillard merged commit d0f42fe into aesara-devs:main Feb 19, 2023
@brandonwillard brandonwillard deleted the add-OpFromGraph-default-updates branch February 19, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacements need to apply to SharedVariable.default_update and OpFromGraphs
1 participant