Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cython-generated code for Python 3.11 #1447

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

brandonwillard
Copy link
Member

Closes #1446

@brandonwillard brandonwillard added bug Something isn't working important Scan Involves the `Scan` `Op` labels Feb 21, 2023
@brandonwillard brandonwillard enabled auto-merge (rebase) February 21, 2023 02:00
@brandonwillard brandonwillard self-assigned this Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #1447 (05c835a) into main (311c901) will increase coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1447      +/-   ##
==========================================
+ Coverage   74.81%   74.86%   +0.05%     
==========================================
  Files         194      194              
  Lines       50007    50107     +100     
  Branches    10572    12098    +1526     
==========================================
+ Hits        37414    37514     +100     
+ Misses      10267    10266       -1     
- Partials     2326     2327       +1     
Impacted Files Coverage Δ
aesara/typed_list/basic.py 85.80% <0.00%> (-2.63%) ⬇️
aesara/tensor/nnet/conv.py 66.94% <0.00%> (-0.23%) ⬇️
aesara/ifelse.py 51.14% <0.00%> (-0.15%) ⬇️
aesara/tensor/extra_ops.py 89.35% <0.00%> (-0.13%) ⬇️
aesara/tensor/blas.py 79.59% <0.00%> (-0.08%) ⬇️
aesara/sandbox/fourier.py 0.00% <0.00%> (ø)
aesara/tensor/nnet/ctc.py 0.00% <0.00%> (ø)
aesara/compile/profiling.py 74.55% <0.00%> (ø)
aesara/compile/compiledir.py 0.00% <0.00%> (ø)
aesara/tensor/nnet/abstract_conv.py 18.80% <0.00%> (ø)
... and 25 more

@rlouf
Copy link
Member

rlouf commented Feb 21, 2023

Should we bump the python version in the CI as well?

@brandonwillard
Copy link
Member Author

Should we bump the python version in the CI as well?

That's exactly what I was thinking (and why I haven't merged this yet).

@brandonwillard brandonwillard force-pushed the update-cython-for-311 branch 2 times, most recently from a677331 to 56a26b3 Compare February 21, 2023 15:38
@brandonwillard brandonwillard merged commit 404e2d4 into aesara-devs:main Feb 21, 2023
@brandonwillard brandonwillard deleted the update-cython-for-311 branch February 21, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important Scan Involves the `Scan` `Op`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cython-generated Scan code is invalid for Python 3.11
2 participants