Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add power and zipf RV #1448

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

Smit-create
Copy link
Member

Fixes #1352
Fixes #1350
Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

@Smit-create Smit-create added enhancement New feature or request random variables Involves random variables and/or sampling NumPy compatibility Op implementation Involves the implementation of an Op labels Feb 21, 2023
@rlouf
Copy link
Member

rlouf commented Feb 21, 2023

Looks good! Can you also add the distributions to the documentation?

I see that the tests fail in CI, but they don't on my machine. We need to figure out what's happening here; is NumPy's output consistent to begin with?

@rlouf rlouf closed this Feb 21, 2023
@rlouf rlouf reopened this Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #1448 (775076d) into main (c433071) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1448   +/-   ##
=======================================
  Coverage   74.86%   74.87%           
=======================================
  Files         194      194           
  Lines       50107    50123   +16     
  Branches    12098    12098           
=======================================
+ Hits        37514    37530   +16     
  Misses      10266    10266           
  Partials     2327     2327           
Impacted Files Coverage Δ
aesara/compile/profiling.py 74.55% <ø> (ø)
aesara/tensor/basic.py 89.99% <ø> (ø)
aesara/tensor/elemwise.py 88.07% <ø> (ø)
aesara/tensor/var.py 87.82% <50.00%> (ø)
aesara/tensor/rewriting/math.py 86.11% <60.00%> (ø)
aesara/link/jax/dispatch/scalar.py 96.72% <100.00%> (ø)
aesara/link/numba/dispatch/elemwise.py 97.12% <100.00%> (ø)
aesara/scalar/basic.py 79.17% <100.00%> (-0.01%) ⬇️
aesara/tensor/inplace.py 100.00% <100.00%> (ø)
aesara/tensor/math.py 90.67% <100.00%> (-0.01%) ⬇️
... and 1 more

@Smit-create Smit-create marked this pull request as ready for review February 21, 2023 17:20
@Smit-create
Copy link
Member Author

Is this good to merge?

@brandonwillard brandonwillard merged commit 055ceb1 into aesara-devs:main Mar 2, 2023
@brandonwillard
Copy link
Member

Is this good to merge?

Yes, thanks a lot!

@Smit-create Smit-create deleted the i-1352-1350 branch March 3, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request NumPy compatibility Op implementation Involves the implementation of an Op random variables Involves random variables and/or sampling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add power RandomVariable Add Zipf RandomVariable
3 participants