Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and doc to sdist #1454

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Add tests and doc to sdist #1454

merged 3 commits into from
Feb 27, 2023

Conversation

maresb
Copy link
Contributor

@maresb maresb commented Feb 23, 2023

This makes it more viable to use the PyPI sdist for building Gentoo, as per #1453 (reply in thread)

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2023

Reverts #1408, but if people find it useful to include the docs in the sdist then we might as well.

@brandonwillard brandonwillard added the setup and installation Relates to the setup and installation of Aesara label Feb 23, 2023
Copy link
Contributor

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pyproject.toml Outdated Show resolved Hide resolved
maresb and others added 2 commits February 23, 2023 22:54
Co-authored-by: Michał Górny <mgorny@gentoo.org>
@maresb
Copy link
Contributor Author

maresb commented Feb 23, 2023

Let's squash-merge when ready

@brandonwillard brandonwillard merged commit d7b2c98 into main Feb 27, 2023
@brandonwillard brandonwillard deleted the add-sdist-files branch February 27, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
setup and installation Relates to the setup and installation of Aesara
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants