Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different sample sizes for empirical JAX sampler tests #1464

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

brandonwillard
Copy link
Member

This PR increases the sample sizes for some empirical JAX sampler tests that use Cramér–von Mises. More specifically, the Student-T and uniform sampler tests have their sample sizes increased.

@brandonwillard brandonwillard added bug Something isn't working testing JAX Involves JAX transpilation labels Mar 5, 2023
@brandonwillard brandonwillard self-assigned this Mar 5, 2023
@brandonwillard brandonwillard linked an issue Mar 5, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #1464 (faa579c) into main (055ceb1) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   74.87%   74.87%           
=======================================
  Files         194      194           
  Lines       50123    50123           
  Branches    12098    12098           
=======================================
  Hits        37530    37530           
  Misses      10266    10266           
  Partials     2327     2327           

@brandonwillard brandonwillard merged commit 84e6d32 into aesara-devs:main Mar 7, 2023
@brandonwillard brandonwillard deleted the fix-new-jax-issue branch March 7, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working JAX Involves JAX transpilation testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random sampling JAX failures caused by jax>=0.4.5
1 participant