Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh: refactor community files #1471

Merged
merged 1 commit into from
Apr 1, 2023
Merged

gh: refactor community files #1471

merged 1 commit into from
Apr 1, 2023

Conversation

SauravMaheshkar
Copy link
Contributor

This PR aims to move the CONTRIBUTING.md and CODE_OF_CONDUCT.md files from the root of the directory to the .github/ directory. Github looks for a contribution guideline file in the following order: .github dir > project root > docs dir (source). Moving the file to the .github/ dir leads to a minimal project structure without any functional change.

@dgerlanc
Copy link
Contributor

Do we have any links to these documents that need updating?

@SauravMaheshkar
Copy link
Contributor Author

Do we have any links to these documents that need updating?

@dgerlanc Addressed in a12acba and e8cd987

Copy link
Contributor

@dgerlanc dgerlanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash these all into a single commit and rebase on top of the main branch?

If you're not comfortable doing that feel free to message me and I can walk you through doing it.

@SauravMaheshkar
Copy link
Contributor Author

Can you squash these all into a single commit and rebase on top of the main branch?

If you're not comfortable doing that feel free to message me and I can walk you through doing it.

Yes thank you, can you walk me through it.

@dgerlanc
Copy link
Contributor

Can you squash these all into a single commit and rebase on top of the main branch?
If you're not comfortable doing that feel free to message me and I can walk you through doing it.

Yes thank you, can you walk me through it.

Happy to do so - feel free to hit me up on Element (@dgerlanc:matrix.org) or the Aesara Discord room (dgerlanc) and we can find a time.

  - Update links in `pyproject.toml` and `README.md`
@dgerlanc
Copy link
Contributor

Can you squash these all into a single commit and rebase on top of the main branch?
If you're not comfortable doing that feel free to message me and I can walk you through doing it.

Yes thank you, can you walk me through it.

Happy to do so - feel free to hit me up on Element (@dgerlanc:matrix.org) or the Aesara Discord room (dgerlanc) and we can find a time.

I merged these into one commit so that the links aren't broken in any of the commits. Feel free to hit me up still if you want to go over how I did in git.

@SauravMaheshkar
Copy link
Contributor Author

broken in any of the commits. Feel free to hit me up still if you want to go over how I did in git.

thank you 😄

@SauravMaheshkar SauravMaheshkar requested review from dgerlanc and removed request for rlouf March 26, 2023 07:34
@dgerlanc dgerlanc merged commit 3eb7cdf into aesara-devs:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants