Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in JAX gengamma #1475

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Conversation

Smit-create
Copy link
Member

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Fixes #1472

@Smit-create Smit-create added bug Something isn't working JAX Involves JAX transpilation random variables Involves random variables and/or sampling labels Mar 14, 2023
brandonwillard
brandonwillard previously approved these changes Mar 14, 2023
@brandonwillard brandonwillard marked this pull request as ready for review March 14, 2023 23:11
@brandonwillard brandonwillard changed the title Fix a typo Fix a typo in JAX gengamma Mar 14, 2023
@brandonwillard brandonwillard enabled auto-merge (rebase) March 14, 2023 23:33
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #1475 (fb57b6e) into main (984ee55) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1475   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files         194      194           
  Lines       50099    50099           
  Branches    12096    12096           
=======================================
  Hits        37586    37586           
  Misses      10189    10189           
  Partials     2324     2324           
Impacted Files Coverage Δ
aesara/link/jax/dispatch/random.py 100.00% <100.00%> (ø)

@brandonwillard brandonwillard merged commit 462d8d5 into aesara-devs:main Mar 15, 2023
@brandonwillard
Copy link
Member

Thanks again, @Smit-create!

@Smit-create Smit-create deleted the i-1472 branch March 15, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working JAX Involves JAX transpilation random variables Involves random variables and/or sampling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible small error in GenGammaRV: "rng_state" instead of "jax_state"
2 participants