Create a base type for shared RNG variables #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
enhancement
brandonwillard
force-pushed
the
create-base-shared-rng-type
branch
from
0df84fb
to
39410ad
Compare
brandonwillard
force-pushed
the
create-base-shared-rng-type
branch
from
39410ad
to
7fa7024
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1476 +/- ##
=======================================
Coverage 75.02% 75.02%
=======================================
Files 194 194
Lines 50099 50102 +3
Branches 12096 12096
=======================================
+ Hits 37586 37589 +3
Misses 10189 10189
Partials 2324 2324
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a base type for shared RNG variables (i.e. a base class for
RandomStateSharedVariableandRandomGeneratorSharedVariable) and fills in some type hints forSharedVariableitself.