-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JAX implementation for InvGammaRV
#1480
Conversation
3dd7e49
to
8c6825e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1480 +/- ##
=======================================
Coverage 75.06% 75.06%
=======================================
Files 194 194
Lines 50091 50101 +10
Branches 12096 12097 +1
=======================================
+ Hits 37600 37610 +10
Misses 10170 10170
Partials 2321 2321
|
InvGammaRV
InvGammaRV
Yes, definitely. |
Is that still an issue now that #1482 is merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some small changes and squashed; should be ready to merge after passing.
It is not an issue anymore. |
Thanks a lot, @PaulScemama! |
Thank you! @brandonwillard I learned a lot. |
This PR is a draft to close #1368. Furthermore, I had to change the
.pre-commit-config.yaml
slightly to pass themypy
check. This bug has been discussed in #1474 (reply in thread).@brandonwillard @rlouf let me know what you both think regarding the
types-setuptools
issue. If it hasn't affected anyone else then I would assume you wouldn't want the change to the.pre-commit-config.yaml
.Here are a few important guidelines and requirements to check before your PR can be merged:
pre-commit
is installed and set up.EDIT:
Something that I didn't realize in the beginning...from wolfram:
"the inverse gamma distribution with shape parameter$\alpha$ and scale parameter $\beta$ is the distribution followed by the inverse of a gamma distribution with shape parameter $\alpha$ and scale parameter $\color{red} 1 / \beta$ ."
Could be useful to say something like:
"the InvGamma(shape, scale) is equivalent to taking the reciprocal of samples from a Gamma(shape, 1 / scale) distribution" in the docs.