Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Python 3.7 #1483

Merged
merged 2 commits into from
Mar 22, 2023

Conversation

brandonwillard
Copy link
Member

This PR removes explicit Python 3.7 support.

@brandonwillard brandonwillard added the dependencies Pull requests that update a dependency file label Mar 21, 2023
@brandonwillard brandonwillard marked this pull request as draft March 21, 2023 00:40
@maresb maresb force-pushed the remove-3.7-support branch 3 times, most recently from 69a3913 to 113d3e1 Compare March 21, 2023 09:54
@maresb
Copy link
Contributor

maresb commented Mar 21, 2023

@brandonwillard, I rebased on main to fix the mypy failure.

I updated the upper Python version in the test matrix to 3.11. If it was deliberate to have it only at 3.10 then we can remove 0107efc. Otherwise we might squash it.

Finally I upgraded the flake8 pre-commit version and removed the respective comment in a separate commit.

@maresb
Copy link
Contributor

maresb commented Mar 21, 2023

If it was deliberate to have it only at 3.10 then we can remove 0107efc.

Ah, right. Numba doesn't yet support 3.11. I'll add a comment.

Copy link
Contributor

@maresb maresb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on test results, but LGTM

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #1483 (20fb999) into main (1da48b5) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1483      +/-   ##
==========================================
+ Coverage   75.02%   75.06%   +0.04%     
==========================================
  Files         194      194              
  Lines       50102    50102              
  Branches    12096    12096              
==========================================
+ Hits        37589    37611      +22     
+ Misses      10189    10170      -19     
+ Partials     2324     2321       -3     

see 11 files with indirect coverage changes

@brandonwillard brandonwillard marked this pull request as ready for review March 22, 2023 00:49
@brandonwillard brandonwillard merged commit 10aa100 into aesara-devs:main Mar 22, 2023
@brandonwillard brandonwillard deleted the remove-3.7-support branch March 22, 2023 00:49
@brandonwillard
Copy link
Member Author

brandonwillard commented Mar 22, 2023

Thanks, as always, @maresb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants