-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Python 3.7 #1483
Remove support for Python 3.7 #1483
Conversation
656467e
to
190a08a
Compare
69a3913
to
113d3e1
Compare
@brandonwillard, I rebased on main to fix the mypy failure. I updated the upper Python version in the test matrix to 3.11. If it was deliberate to have it only at 3.10 then we can remove 0107efc. Otherwise we might squash it. Finally I upgraded the flake8 pre-commit version and removed the respective comment in a separate commit. |
Ah, right. Numba doesn't yet support 3.11. I'll add a comment. |
113d3e1
to
20fb999
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting on test results, but LGTM
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1483 +/- ##
==========================================
+ Coverage 75.02% 75.06% +0.04%
==========================================
Files 194 194
Lines 50102 50102
Branches 12096 12096
==========================================
+ Hits 37589 37611 +22
+ Misses 10189 10170 -19
+ Partials 2324 2321 -3 |
Thanks, as always, @maresb! |
This PR removes explicit Python 3.7 support.