Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes pydot2 dependency #1493

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

Ankit-Dhankhar
Copy link
Contributor

@Ankit-Dhankhar Ankit-Dhankhar commented Apr 16, 2023

This PR fixes #1488

This PR removes dependency on pydot2 which throws error while installing using pip due to incompibility of setuptools (>v58) with use_2to3 (ref stackoverflow link).

More details about the issue can be found in referenced issue #1488

PR Checklist

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.

@brandonwillard brandonwillard added bug Something isn't working setup and installation Relates to the setup and installation of Aesara labels Apr 17, 2023
@brandonwillard brandonwillard merged commit c70c0e1 into aesara-devs:main Apr 17, 2023
@brandonwillard
Copy link
Member

Thanks, @Ankit-Dhankhar!

@Ankit-Dhankhar Ankit-Dhankhar deleted the bugfix/pydot2-dep branch April 19, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working setup and installation Relates to the setup and installation of Aesara
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"error in pydot2 setup command: use_2to3 is invalid" while installing requirements-rtd.txt dependencies
2 participants