Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python updates for Elemwise broadcasting #336

Merged

Conversation

brandonwillard
Copy link
Member

This PR addresses the Elemwise broadcasting issue in #335 from the Python implementation side. It also includes a few minor fixes and updates the the C compilation process.

@brandonwillard brandonwillard self-assigned this Mar 13, 2021
@brandonwillard brandonwillard force-pushed the elemwise-broadcast-issue branch 3 times, most recently from e54112e to 8a59854 Compare March 14, 2021 05:00
@codecov
Copy link

codecov bot commented Mar 14, 2021

Codecov Report

Merging #336 (3d77895) into master (f0392db) will increase coverage by 0.02%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #336      +/-   ##
==========================================
+ Coverage   71.94%   71.96%   +0.02%     
==========================================
  Files         166      166              
  Lines       54634    54627       -7     
==========================================
+ Hits        39305    39314       +9     
+ Misses      15329    15313      -16     
Impacted Files Coverage Δ
aesara/link/utils.py 52.45% <28.57%> (+0.19%) ⬆️
aesara/link/c/exceptions.py 80.00% <75.00%> (-20.00%) ⬇️
aesara/compile/compilelock.py 100.00% <100.00%> (ø)
aesara/link/c/basic.py 92.18% <100.00%> (+0.02%) ⬆️
aesara/link/c/cmodule.py 57.67% <100.00%> (+1.21%) ⬆️
aesara/tensor/elemwise.py 92.00% <100.00%> (+0.01%) ⬆️
aesara/tensor/random/basic.py 100.00% <100.00%> (ø)
aesara/configdefaults.py 80.39% <0.00%> (+0.24%) ⬆️

@brandonwillard brandonwillard force-pushed the elemwise-broadcast-issue branch from 8a59854 to 3d77895 Compare March 16, 2021 19:00
@brandonwillard brandonwillard merged commit 4705e01 into aesara-devs:master Mar 18, 2021
@brandonwillard brandonwillard deleted the elemwise-broadcast-issue branch March 18, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant