-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose standard_normal
to RandomStream
#530
Conversation
c16d09c
to
988fdb0
Compare
force-pushed to deal with the pre-commit fail. Not sure why it did not catch it since I ran it locally. |
988fdb0
to
22c98c5
Compare
Okay, for some reason the RandomStream class is still not picking up the new attribute at: aesara/aesara/tensor/random/utils.py Lines 167 to 169 in a784084
EDIT: I see the issue now. the partial function is not seen as an instance of aesara/aesara/tensor/random/utils.py Lines 174 to 183 in a784084
|
044dcd2
to
658c0d0
Compare
658c0d0
to
7298c16
Compare
63fe2e6
to
ecae4b3
Compare
@twiecki lets try one more time. I fixed the test failure caused by the linter. |
ecae4b3
to
d248e69
Compare
Codecov Report
@@ Coverage Diff @@
## main #530 +/- ##
=======================================
Coverage 76.54% 76.55%
=======================================
Files 149 149
Lines 46726 46730 +4
Branches 10264 10264
=======================================
+ Hits 35768 35772 +4
Misses 8350 8350
Partials 2608 2608
|
Thanks @zoj613! |
Exposes
standard_normal
to the random namespace for convenience and to be more consistent with the behavior ofnp.random.RandomState
.closes #528