Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get_scalar_constant_value #643

Merged
merged 37 commits into from
Nov 15, 2021
Merged

Refactor get_scalar_constant_value #643

merged 37 commits into from
Nov 15, 2021

Commits on Nov 11, 2021

  1. Fix strict type equality in aesara.tensor.subtensor_opt

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    7a5b1ff View commit details
    Browse the repository at this point in the history

  2. Use Type instead of CType in get_scalar_constant_value

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    5954079 View commit details
    Browse the repository at this point in the history

  3. Fix strict type checking in aesara.tensor.basic_opt

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    cd3e134 View commit details
    Browse the repository at this point in the history

  4. Fix local_join_make_vector docstring

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    2f1b3eb View commit details
    Browse the repository at this point in the history

  5. Clarify assert statement in test_get_vector_length

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    2586e67 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary print statements and comments

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    9b8f91e View commit details
    Browse the repository at this point in the history

  7. Add local Subtensor of Shape canonicalization

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    d471db3 View commit details
    Browse the repository at this point in the history

  8. Add local Shape of SpecifyShape canonicalization

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    4241f8a View commit details
    Browse the repository at this point in the history

  9. Add local Shape_i of broadcastable dimension canonicalization

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    5b4a857 View commit details
    Browse the repository at this point in the history

  10. Add missing info to Rebroadcast str representation

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    e77a484 View commit details
    Browse the repository at this point in the history

  11. Fix local_upcast_elemwise_constant_inputs docstring

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    5e3113f View commit details
    Browse the repository at this point in the history

  12. Remove use of numpy_scalar in get_scalar_constant_value

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    8e57cc8 View commit details
    Browse the repository at this point in the history

  13. Remove impossible condition in get_scalar_constant_value logic

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    cf0b2c9 View commit details
    Browse the repository at this point in the history

  14. Make aesara.tensor.basic exceptions use f-strings

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    c8ca89f View commit details
    Browse the repository at this point in the history

  15. Simplify as_tensor_variable imports in aesara.tensor.elemwise

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    d142225 View commit details
    Browse the repository at this point in the history

  16. Replace old style exception in aesara.tensor.subtensor_opt

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    b1a8fa9 View commit details
    Browse the repository at this point in the history

  17. Add type annotations to aesara.tensor.subtensor.as_index_constant

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    c68677e View commit details
    Browse the repository at this point in the history

  18. Refactor get_canonical_form_slice so that it uses as_index_literal

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    350268b View commit details
    Browse the repository at this point in the history

  19. Use pytest's parameterize for TestSubtensor.test_ellipsis

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    3e2c472 View commit details
    Browse the repository at this point in the history

  20. Fix flaky RNG usage in tests.tensor.test_math.test_cov

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    3b5ec3d View commit details
    Browse the repository at this point in the history

  21. Simplify construction of aesara.tensor.basic_opt.local_elemwise_alloc

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    6825e02 View commit details
    Browse the repository at this point in the history

  22. Refactor tests.tensor.test_basic_opt tests 

    * Convert tests to pytest `parametrized` tests
* Use `pytest.raises`
* Remove unused timing code and methods
    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    7315bc7 View commit details
    Browse the repository at this point in the history

  23. Move _fill_chain to aesara.tensor.math_opt

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    582f19f View commit details
    Browse the repository at this point in the history

  24. Use register_* decorators in basic_opt and math_opt

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    e5df6aa View commit details
    Browse the repository at this point in the history

  25. Correctly set tracked Op on local_track_shape_i

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    4359ca7 View commit details
    Browse the repository at this point in the history

  26. Clean up comments in basic_opt and math_opt

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    7b9b445 View commit details
    Browse the repository at this point in the history

  27. Prevent unnecessary shadowing of builtin input

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    066709c View commit details
    Browse the repository at this point in the history

  28. Extract get_constant from AlgebraicCanonizer

    @brandonwillard
    brandonwillard committed Nov 11, 2021
    Configuration menu
    Copy the full SHA
    d7358d3 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2021

  1. Refactor local_add_specialize and test_local_add_specialize 

    These changes "flatten" the nested conditions that lead to the replacement
logic.

They also clarify the tests that are labeled as being for
`local_add_specialize`, which actually aren't.  Also, the unrelated tests
implicitly relied on the canonicalizations built into
`get_scalar_constant_value`; now, the actual canonicalizations are required in
anticipation of `get_scalar_constant_value`'s replacement.
    @brandonwillard
    brandonwillard committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    d26b992 View commit details
    Browse the repository at this point in the history

  2. Update verbose optimizer format and print individual steps in LocalOp… 

    …tGroup
    @brandonwillard
    brandonwillard committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    e792667 View commit details
    Browse the repository at this point in the history

  3. Remove debug print message in aesara.ifelse.CondMerge

    @brandonwillard
    brandonwillard committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    20601b7 View commit details
    Browse the repository at this point in the history

  4. Move scalarconsts_rest to math_opt

    @brandonwillard
    brandonwillard committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    63dd23a View commit details
    Browse the repository at this point in the history

  5. Add missing get_scalar_constant_value tests

    @brandonwillard
    brandonwillard committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    9144137 View commit details
    Browse the repository at this point in the history

  6. Refactor test_local_zero_div 

    * Use `pytest.mark.parameterize`
* Remove reliance on `get_scalar_constant_value`
    @brandonwillard
    brandonwillard committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    2563350 View commit details
    Browse the repository at this point in the history

  7. Make sure repeats argument is int64

    @brandonwillard
    brandonwillard committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    1d14ee9 View commit details
    Browse the repository at this point in the history

  8. Implement basic rewrites for Unique

    @brandonwillard
    brandonwillard committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    287f7a0 View commit details
    Browse the repository at this point in the history

  9. Remove scan__debug config option

    @brandonwillard
    brandonwillard committed Nov 14, 2021
    Configuration menu
    Copy the full SHA
    3a3b122 View commit details
    Browse the repository at this point in the history