Make input mismatch TypeError in make_node more readable

[ricardoV94]

import aesara
import aesara.tensor as at

class MyOp(aesara.graph.op.Op):
    itypes = [at.dvector, at.dvector, at.dvector]
    otypes = [at.dscalar]
    def perform(self, node, inputs, outputs):
        pass
    
MyOp()(at.vector(), at.scalar(), at.vector())

Before:

Traceback (most recent call last):
  File "/home/ricardo/Documents/Projects/aesara/venv/lib/python3.8/site-packages/IPython/core/interactiveshell.py", line 3441, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-2-c79d16f9907a>", line 10, in <module>
    MyOp()(at.vector(), at.scalar(), at.dvector())
  File "/home/ricardo/Documents/Projects/aesara/aesara/graph/op.py", line 275, in __call__
    node = self.make_node(*inputs, **kwargs)
  File "/home/ricardo/Documents/Projects/aesara/aesara/graph/op.py", line 227, in make_node
    raise TypeError(
TypeError: We expected inputs of types '[TensorType(float64, vector), TensorType(float64, vector), TensorType(float64, vector)]' but got types '[TensorType(float64, vector), TensorType(float64, scalar), TensorType(float64, vector)]'

After:

Traceback (most recent call last):
  File "/home/ricardo/Documents/Projects/aesara/venv/lib/python3.8/site-packages/IPython/core/interactiveshell.py", line 3441, in run_code
    exec(code_obj, self.user_global_ns, self.user_ns)
  File "<ipython-input-2-ddfd178ce0c4>", line 13, in <module>
    MyOp()(at.vector(), at.scalar(), at.vector())
  File "/home/ricardo/Documents/Projects/aesara/aesara/graph/op.py", line 284, in __call__
    node = self.make_node(*inputs, **kwargs)
  File "/home/ricardo/Documents/Projects/aesara/aesara/graph/op.py", line 228, in make_node
    raise TypeError(
TypeError: Invalid input types for Op MyOp:
Input 2/3: Expected TensorType(float64, vector), got TensorType(float64, scalar)

[codecov]

Codecov Report

Merging #655 (327bd1e) into main (620edab) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   77.15%   77.16%           
=======================================
  Files         156      156           
  Lines       47007    47007           
  Branches    10281    10281           
=======================================
+ Hits        36269    36271    +2     
+ Misses       8151     8150    -1     
+ Partials     2587     2586    -1     

Impacted Files	Coverage Δ
aesara/graph/op.py	68.37% <ø> (+0.42%)	⬆️

[brandonwillard]

The Codecov annotation says that these changes are being tested (I also don't see a test for this in tests.graph.test_basic). If that's true, we need a test; otherwise, this is good to merge.

[brandonwillard]

Looks like the regex pattern needs adjustment.

[ricardoV94]

Looks like the regex pattern needs adjustment.

Weird. It was passing locally... Will have a look

[ricardoV94]

It was a float32 test thing... Should be fixed now