Use NumPy C API to perform DimShuffle steps in its C implementation
#701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
fix-dimshuffle-views-c-code
branch
from
bf785ac
to
4d7c16b
Compare
brandonwillard
force-pushed
the
fix-dimshuffle-views-c-code
branch
from
4d7c16b
to
a06fbe0
Compare
ricardoV94
reviewed
Dec 15, 2021
ricardoV94
reviewed
Dec 15, 2021
These changes remove the stride-based manual computation of the new shape, since those are potentially sensitive to broadcasted arrays with no strides.
brandonwillard
force-pushed
the
fix-dimshuffle-views-c-code
branch
from
ea60b35
to
d648969
Compare
brandonwillard
force-pushed
the
fix-dimshuffle-views-c-code
branch
from
d648969
to
a119a25
Compare
Codecov Report
@@ Coverage Diff @@
## main #701 +/- ##
==========================================
- Coverage 77.66% 77.66% -0.01%
==========================================
Files 152 152
Lines 46973 46961 -12
Branches 10894 10891 -3
==========================================
- Hits 36480 36470 -10
+ Misses 7895 7894 -1
+ Partials 2598 2597 -1
|
ricardoV94
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the custom view array creation in
DimShuffle's C implementation with calls to NumPy's C API that match the Python implementation. It also replaces the manual shape creation steps inReshape's C implementation with a call to a NumPy helper function.Closes #699