Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for input checks in tensor/signal/pool.py #713

Merged
merged 4 commits into from
Jan 3, 2022

Conversation

aerubanov
Copy link
Contributor

This PR adds tests that are basically to check that suitable exceptions are raised if incorrect input data is received in tensor/signal/pool.py. This pool-request is related to issue #605.

@brandonwillard brandonwillard added enhancement New feature or request testing labels Dec 31, 2021
@brandonwillard
Copy link
Member

Thanks for the PR!

I noticed that there's a merge commit in this branch. We won't be able to merge this PR with such commits present, so you'll need to rebase this onto upstream/main in order to remove the commits.

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #713 (ea8a1d4) into main (20581c3) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   78.03%   78.17%   +0.13%     
==========================================
  Files         152      152              
  Lines       47719    47719              
  Branches    10893    10893              
==========================================
+ Hits        37237    37302      +65     
+ Misses       7889     7849      -40     
+ Partials     2593     2568      -25     
Impacted Files Coverage Δ
aesara/tensor/signal/pool.py 69.34% <0.00%> (+8.16%) ⬆️

@aerubanov
Copy link
Contributor Author

@brandonwillard , Thanks for quick responce! I rebased the branch.

@brandonwillard
Copy link
Member

The failure observed in CI should be fixed by #716.

@brandonwillard brandonwillard merged commit cfa867b into aesara-devs:main Jan 3, 2022
@aerubanov aerubanov deleted the test_pool branch January 4, 2022 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants