Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce aesara.as_symbolic #743

Merged

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Jan 11, 2022

This PR introduces the aesara.as_symbolic dispatch function, which converts all eligible objects to Variables. Unlike aesara.tensor.as_tensor_variable, as_symbolic will convert Nones, slices, or any other types that have equivalent Aesara Types.

`aesara.as_symbolic` is a new function that converts all eligible objects to
`Variable`s.  Unlike `aesara.tensor.as_tensor_variable`, `as_symbolic` will
convert `None`s and `slice`s, or any other types that have equivalent Aesara `Type`s.
@brandonwillard brandonwillard added the enhancement New feature or request label Jan 11, 2022
@brandonwillard brandonwillard self-assigned this Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #743 (a90c14d) into main (3edbbc4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   78.16%   78.17%           
=======================================
  Files         152      152           
  Lines       47652    47661    +9     
  Branches    10880    10881    +1     
=======================================
+ Hits        37249    37258    +9     
  Misses       7846     7846           
  Partials     2557     2557           
Impacted Files Coverage Δ
aesara/graph/opt.py 65.74% <100.00%> (ø)
aesara/tensor/type_other.py 82.75% <100.00%> (+1.98%) ⬆️

@brandonwillard brandonwillard merged commit b088cc8 into aesara-devs:main Jan 12, 2022
@brandonwillard brandonwillard deleted the add-as_symbolic-dispatch branch January 12, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant