Add rewrite to merge consecutive Joined Subtensors
#760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
joined_subtensors
branch
2 times, most recently
from
912d867
to
00da564
Compare
Codecov Report
@@ Coverage Diff @@
## main #760 +/- ##
=======================================
Coverage 78.91% 78.92%
=======================================
Files 152 152
Lines 47657 47698 +41
Branches 10852 10861 +9
=======================================
+ Hits 37609 37646 +37
- Misses 7548 7550 +2
- Partials 2500 2502 +2
|
brandonwillard
requested changes
Jan 17, 2022
ricardoV94
force-pushed
the
joined_subtensors
branch
2 times, most recently
from
f5441ae
to
cd6fd7f
Compare
brandonwillard
changed the title
Joined Subtensors
brandonwillard
requested changes
Jan 19, 2022
ricardoV94
force-pushed
the
joined_subtensors
branch
4 times, most recently
from
168a2ce
to
f52bce5
Compare
ricardoV94
force-pushed
the
joined_subtensors
branch
2 times, most recently
from
d455cef
to
675ac90
Compare
brandonwillard
requested changes
Feb 22, 2022
ricardoV94
force-pushed
the
joined_subtensors
branch
from
675ac90
to
2d17abf
Compare
ricardoV94
force-pushed
the
joined_subtensors
branch
from
2d17abf
to
49d4ee0
Compare
brandonwillard
previously approved these changes
Apr 28, 2022
ricardoV94
force-pushed
the
joined_subtensors
branch
from
49d4ee0
to
2df3965
Compare
ricardoV94
force-pushed
the
joined_subtensors
branch
from
2df3965
to
81dc59f
Compare
|
Fixed a wrong assumption that we could perform this rewrite as long as the steps were equal. Also got rid of |
ricardoV94
force-pushed
the
joined_subtensors
branch
from
81dc59f
to
e2e54cc
Compare
ricardoV94
force-pushed
the
joined_subtensors
branch
from
e2e54cc
to
ccd8360
Compare
brandonwillard
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing a bit with this kind of rewrites recently, which appeared for me when undoing
at.diffoperations which reduce the first axis index.concatenate(([x[:1], x[1:])) -> xI am not sure this is a useful rewrite to have in the codebase, let me know what you think.
If this is useful, it will probably still need a bit of cleanup, as I've never worked with SubTensors before.