Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken logger warning #781

Conversation

brandonwillard
Copy link
Member

This PR removes a broken warning and old style logger from aesara.tensor.math_opt.

@brandonwillard brandonwillard added bug Something isn't working refactor This issue involves refactoring labels Jan 23, 2022
@brandonwillard brandonwillard added this to the Clean up after Theano milestone Jan 23, 2022
@brandonwillard brandonwillard linked an issue Jan 23, 2022 that may be closed by this pull request
ricardoV94
ricardoV94 previously approved these changes Jan 23, 2022
@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #781 (fb90f87) into main (77bcd68) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #781      +/-   ##
==========================================
+ Coverage   78.41%   78.43%   +0.01%     
==========================================
  Files         152      152              
  Lines       47793    47788       -5     
  Branches    10884    10884              
==========================================
+ Hits        37479    37482       +3     
+ Misses       7766     7761       -5     
+ Partials     2548     2545       -3     
Impacted Files Coverage Δ
aesara/tensor/math_opt.py 86.57% <100.00%> (+0.34%) ⬆️
aesara/misc/safe_asarray.py 69.23% <0.00%> (+15.38%) ⬆️

@brandonwillard brandonwillard merged commit 55f5424 into aesara-devs:main Jan 23, 2022
@brandonwillard brandonwillard deleted the remove-AlgebraicCanonizer-warnings branch January 23, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor This issue involves refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph Optimizer fails after graph transform
2 participants