Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed behaviour of at.subtensor.take when axis is None #787

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

kc611
Copy link
Contributor

@kc611 kc611 commented Jan 24, 2022

A fix for #786

@kc611 kc611 requested a review from ricardoV94 January 24, 2022 15:23
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #787 (24d88b5) into main (77bcd68) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #787   +/-   ##
=======================================
  Coverage   78.41%   78.42%           
=======================================
  Files         152      152           
  Lines       47793    47786    -7     
  Branches    10884    10883    -1     
=======================================
- Hits        37479    37478    -1     
+ Misses       7766     7762    -4     
+ Partials     2548     2546    -2     
Impacted Files Coverage Δ
aesara/tensor/subtensor.py 89.42% <100.00%> (-0.22%) ⬇️
aesara/tensor/math_opt.py 86.57% <0.00%> (+0.34%) ⬆️
aesara/misc/safe_asarray.py 69.23% <0.00%> (+15.38%) ⬆️

@brandonwillard brandonwillard added the bug Something isn't working label Jan 24, 2022
@brandonwillard brandonwillard linked an issue Jan 24, 2022 that may be closed by this pull request
@brandonwillard brandonwillard merged commit 7826c27 into aesara-devs:main Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tensor.take bug
2 participants