Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hint to RandomVariable.rng_fn #827

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Add type hint to RandomVariable.rng_fn #827

merged 1 commit into from
Oct 18, 2022

Conversation

sujitpal
Copy link
Contributor

Type hint added to RandomVariable.rng_fn based on pymc-devs/pymc#5326

Thank you for opening a PR!

Here are a few important guidelines and requirements to check before your PR can be merged:

  • There is an informative high-level description of the changes.
  • The description and/or commit message(s) references the relevant GitHub issue(s).
  • pre-commit is installed and set up.
  • The commit messages follow these guidelines.
  • The commits correspond to relevant logical changes, and there are no commits that fix changes introduced by other commits in the same branch/BR.
  • There are tests covering the changes introduced in the PR.

Don't worry, your PR doesn't need to be in perfect order to submit it. As development progresses and/or reviewers request changes, you can always rewrite the history of your feature/PR branches.

If your PR is an ongoing effort and you would like to involve us in the process, simply make it a draft PR.

@brandonwillard brandonwillard changed the title PYMC-5326: added type hint to RandomVariable.rng_fn Add type hint to RandomVariable.rng_fn Feb 18, 2022
brandonwillard
brandonwillard previously approved these changes Feb 27, 2022
Copy link
Member

@brandonwillard brandonwillard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition!

rlouf
rlouf previously approved these changes Oct 17, 2022
Copy link
Member

@rlouf rlouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on main. This is mergeable provided the CI is all green.

@brandonwillard brandonwillard added the typing Work related to type checking label Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #827 (9614f42) into main (aa5223c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files         174      174           
  Lines       48605    48605           
  Branches    10340    10340           
=======================================
  Hits        36014    36014           
  Misses      10305    10305           
  Partials     2286     2286           
Impacted Files Coverage Δ
aesara/tensor/random/op.py 97.40% <100.00%> (ø)

@brandonwillard brandonwillard merged commit 77df667 into aesara-devs:main Oct 18, 2022
@brandonwillard
Copy link
Member

@sujitpal, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typing Work related to type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants