Make Features less stateful
#832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
make-features-less-stateful
branch
from
320ad0a
to
e32dc33
Compare
brandonwillard
force-pushed
the
make-features-less-stateful
branch
from
e32dc33
to
c53e48e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
==========================================
+ Coverage 74.87% 75.00% +0.13%
==========================================
Files 194 194
Lines 50123 50072 -51
Branches 12098 12095 -3
==========================================
+ Hits 37530 37559 +29
+ Misses 10266 10189 -77
+ Partials 2327 2324 -3
|
ricardoV94
reviewed
Feb 22, 2022
brandonwillard
force-pushed
the
make-features-less-stateful
branch
from
0d25040
to
c2e041a
Compare
These changes make `History` less stateful--among other things.
brandonwillard
force-pushed
the
make-features-less-stateful
branch
from
c2e041a
to
d54ee84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves most
Features' state (e.g. variables/collections used to track the state of aFunctionGraph) to theFunctionGraphupon which theFeatures are operating, instead of dedicating oneFeatureand its state to a singleFunctionGraph—as is currently done. With these changes, a few complications surroundingFunctionGraphpickleing and the general dynamic addition/attachment ofFeatures are more easily addressed and/or avoided altogether.Some more details:
Features aren't truly stateful in a way that makes the relevant state specific to theFeatureas much as theFunctionGraph. In other words, mostFeatures really only care about the state of theFunctionGraphs on which they operate, so, if that state is held by theFunctionGraphs themselves,Features can be more versatile.Features from oneFunctionGraphto another (e.g. as is attempted inFunctionGraph.clone_get_equiv), because manyFeatures are unnecessarily dedicated to a singleFunctionGraph.