-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typing issues in core modules #837
Merged
brandonwillard
merged 16 commits into
aesara-devs:main
from
brandonwillard:fix-some-graph-subpackage-typing
Mar 2, 2022
Merged
Fix typing issues in core modules #837
brandonwillard
merged 16 commits into
aesara-devs:main
from
brandonwillard:fix-some-graph-subpackage-typing
Mar 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
force-pushed
the
fix-some-graph-subpackage-typing
branch
5 times, most recently
from
March 2, 2022 02:15
08c7c85
to
7ebe2a2
Compare
brandonwillard
added
enhancement
New feature or request
refactor
This issue involves refactoring
labels
Mar 2, 2022
brandonwillard
force-pushed
the
fix-some-graph-subpackage-typing
branch
2 times, most recently
from
March 2, 2022 05:13
95d6cf2
to
8c9fa1f
Compare
brandonwillard
force-pushed
the
fix-some-graph-subpackage-typing
branch
from
March 2, 2022 05:24
8c9fa1f
to
2cf550c
Compare
brandonwillard
force-pushed
the
fix-some-graph-subpackage-typing
branch
from
March 2, 2022 17:26
310331e
to
ef00cc9
Compare
Codecov Report
@@ Coverage Diff @@
## main #837 +/- ##
==========================================
+ Coverage 78.39% 78.43% +0.04%
==========================================
Files 152 154 +2
Lines 47640 47708 +68
Branches 10841 10842 +1
==========================================
+ Hits 37347 37421 +74
+ Misses 7750 7747 -3
+ Partials 2543 2540 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
refactor
This issue involves refactoring
typing
Work related to type checking
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some typing issues in core Aesara modules and enables them for Mypy checking from here on.