Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a memory leak in the C implementation of DimShuffle #854

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

brandonwillard
Copy link
Member

@brandonwillard brandonwillard commented Mar 11, 2022

Closes #852 and #849.

@codecov
Copy link

codecov bot commented Mar 11, 2022

Codecov Report

Merging #854 (5cfb7ea) into main (3d8553f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #854   +/-   ##
=======================================
  Coverage   78.44%   78.44%           
=======================================
  Files         154      154           
  Lines       47749    47749           
  Branches    10848    10848           
=======================================
+ Hits        37456    37458    +2     
+ Misses       7750     7749    -1     
+ Partials     2543     2542    -1     
Impacted Files Coverage Δ
aesara/tensor/elemwise.py 87.43% <0.00%> (+0.26%) ⬆️

@brandonwillard brandonwillard merged commit 4ab08de into aesara-devs:main Mar 11, 2022
@brandonwillard brandonwillard deleted the fix-dimshuffle-leak branch March 11, 2022 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in DimShuffle Memory leak with grad(sum(M @ v), v) where M is shared.
1 participant