Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Scan.truncate_gradient default value and type #892

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fix Scan.truncate_gradient default value and type #892

merged 1 commit into from
Apr 7, 2022

Conversation

brandonwillard
Copy link
Member

This PR reverts Scan.truncate_gradient back to an int type.

@brandonwillard brandonwillard self-assigned this Apr 7, 2022
@brandonwillard brandonwillard added bug Something isn't working Scan Involves the `Scan` `Op` labels Apr 7, 2022
@brandonwillard brandonwillard mentioned this pull request Apr 7, 2022
Closed
@brandonwillard brandonwillard mentioned this pull request Apr 7, 2022
Open
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #892 (e76475e) into main (f7a506f) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   78.86%   78.86%           
=======================================
  Files         152      152           
  Lines       47639    47644    +5     
  Branches    10841    10841           
=======================================
+ Hits        37569    37574    +5     
  Misses       7565     7565           
  Partials     2505     2505
Impacted Files Coverage Δ
aesara/scan/op.py 83.90% <ø> (ø)
aesara/link/jax/dispatch.py 81.77% <0.00%> (+0.15%) ⬆️

@brandonwillard brandonwillard merged commit 16fce52 into aesara-devs:main Apr 7, 2022
@brandonwillard brandonwillard deleted the fix-scan-truncate-gradient-type branch April 7, 2022 20:32
@brandonwillard brandonwillard linked an issue Apr 7, 2022 that may be closed by this pull request
Gradient with respect to scan logprob raises TypeError #893
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94 ricardoV94 approved these changes

Assignees

@brandonwillard brandonwillard

Labels
bug Something isn't working Scan Involves the `Scan` `Op`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gradient with respect to scan logprob raises TypeError
2 participants
@brandonwillard @ricardoV94