Use SeedSequence in RandomStream
#939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonwillard
added
enhancement
ricardoV94
reviewed
Apr 29, 2022
Mostly just for backward compatibility, but, now, it's useful for the Numba backend as well—at least until something like numba/numba#7900 goes through. |
brandonwillard
force-pushed
the
use-SeedSequence-in-RandomStream
branch
2 times, most recently
from
43e4dc9
to
aa6d2b9
Compare
brandonwillard
force-pushed
the
use-SeedSequence-in-RandomStream
branch
from
aa6d2b9
to
b6dc523
Compare
Codecov Report
@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 78.91% 78.91%
=======================================
Files 152 152
Lines 47657 47660 +3
Branches 10852 10853 +1
=======================================
+ Hits 37609 37612 +3
Misses 7548 7548
Partials 2500 2500
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #936 and removes the old/deprecated attributes that
RandomStreamadds to the variables it generates (e.g..rng,.update).