Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM dev environment dependencies #960

Merged
merged 1 commit into from
Nov 26, 2022

Conversation

dgerlanc
Copy link
Contributor

@dgerlanc dgerlanc commented May 16, 2022

The environment-arm.yml file is a copy of environment.yml with
Intel MKL dependencies replaced with OpenBLAS.

We may want to update the documentation on installing aesara on
Mac OS or complete the fix for #127 before merging this PR. Without
resolving #127, aesara will continue to have problems on Mac OS.

I have started a branch re: #127 here.

Currently, with this environment, you can create a working OS X
environment for aesara so long as you update the cxxflags, e.g.
setting ~/.aesararc to:

[global]

[gcc]
cxxflags=-Wno-c++11-narrowing

Resolves: #934

twiecki
twiecki previously approved these changes May 31, 2022
@twiecki
Copy link
Contributor

twiecki commented May 31, 2022

I think in general, fixing the blas implementation is a bit heavy-handed. Ideally there are instructions on which to use, even though it's a bit confusing for users.

What are these env files actually used for? We have better ones in the conda-forge repo where mkl was already removed.

@dgerlanc
Copy link
Contributor Author

dgerlanc commented May 31, 2022

I think in general, fixing the blas implementation is a bit heavy-handed. Ideally there are instructions on which to use, even though it's a bit confusing for users. What are these env files actually used for? We have better ones in the conda-forge repo where mkl was already removed.

The environment.yml and environment-arm.yml can be used to create a dev environment on x86 or Arm. In theory, users should not be getting involved with these and just including aesara and their desired BLAS implementation in their project environment.yml.

We should indicate in the documentation that these are to be used if you want to contribute to aesara, not simply use it as a library.

Comment on lines 40 to 45
# code style
- black
- isort
# For linting
- flake8
- pep8
- pyflakes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# code style
- black
- isort
# For linting
- flake8
- pep8
- pyflakes

I believe these are all covered by pre-commit now.

@dgerlanc dgerlanc force-pushed the arm-blas-environment branch 2 times, most recently from c5c46fe to 69c8aa6 Compare November 21, 2022 17:18
brandonwillard pushed a commit that referenced this pull request Nov 22, 2022
[Problem] As mentioned in #960, there are some redundant dependencies in
the environment.yml file
[Solution] Removed the redundant dependencies(e.g. black, isort, flake8,
pep8 and pyflakes)
The `environment-arm.yml` file is a copy of `environment.yml` with
Intel MKL dependencies replaced with OpenBLAS.

Resolves: aesara-devs#934
@dgerlanc dgerlanc merged commit f749f2f into aesara-devs:main Nov 26, 2022
@dgerlanc dgerlanc deleted the arm-blas-environment branch November 26, 2022 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Mac ARM Dev Environment
3 participants