-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ARM dev environment dependencies #960
Conversation
f3a52b9
to
17a3363
Compare
I think in general, fixing the blas implementation is a bit heavy-handed. Ideally there are instructions on which to use, even though it's a bit confusing for users. What are these env files actually used for? We have better ones in the conda-forge repo where mkl was already removed. |
The We should indicate in the documentation that these are to be used if you want to contribute to |
environment-arm.yml
Outdated
# code style | ||
- black | ||
- isort | ||
# For linting | ||
- flake8 | ||
- pep8 | ||
- pyflakes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# code style | |
- black | |
- isort | |
# For linting | |
- flake8 | |
- pep8 | |
- pyflakes |
I believe these are all covered by pre-commit
now.
17a3363
to
fbe593d
Compare
c5c46fe
to
69c8aa6
Compare
69c8aa6
to
c485db3
Compare
[Problem] As mentioned in #960, there are some redundant dependencies in the environment.yml file [Solution] Removed the redundant dependencies(e.g. black, isort, flake8, pep8 and pyflakes)
The `environment-arm.yml` file is a copy of `environment.yml` with Intel MKL dependencies replaced with OpenBLAS. Resolves: aesara-devs#934
c485db3
to
4048a9b
Compare
The
environment-arm.yml
file is a copy ofenvironment.yml
withIntel MKL dependencies replaced with OpenBLAS.
We may want to update the documentation on installing
aesara
onMac OS or complete the fix for #127 before merging this PR. Without
resolving #127,
aesara
will continue to have problems on Mac OS.I have started a branch re: #127 here.
Currently, with this environment, you can create a working OS X
environment for
aesara
so long as you update thecxxflags
, e.g.setting
~/.aesararc
to:Resolves: #934