[BUG] Search for fields across associations

[anhnk]

Versions Used
Kaffy: 0.10.3
Phoenix: 1.7.18
Elixir: 1.14.1

What's actually happening?

An error is raised when association is used in search fields. It looks like the query builder didn't use the association at all.

I've narrowed down to the code here in resource_query but couldn't make any further progress.

This is the error:

Postgrex.Error at GET /admin/user/post
ERROR 42703 (undefined_column) column p0.username does not exist

    query: SELECT p0."id", p0."user_id", p0."inserted_at", p0."updated_at" FROM "posts" AS p0 LEFT OUTER JOIN "users" AS u1 ON u1."id" = p0."user_id" WHERE (p0."username"::varchar ILIKE $1) ORDER BY p0."id" DESC LIMIT $2 OFFSET $3

    hint: Perhaps you meant to reference the column "u1.username".

This is my code:

defmodule Mode.Kaffy.PostAdmin do
   def search_fields(_schema) do
    [
      user: [:username]
    ]
  end

What should happen instead?

The Query builder should use association for search field with association.

Screenshots
If applicable, add screenshots to help explain your problem.

[anhnk]

I downgraded to v0.10.2 and it worked. It's possible that the bug was introduced in this commit.

[ghenry]

Apologies for this. Will have a look. If you a PR, that would be much appreciated. Then we can do a new release.

…

On Sun, 15 Dec 2024, 05:09 Anh Do, ***@***.***> wrote: I downgraded to v0.10.2 and it worked. It's possible that the bug was introduced in this commit <f1dea1d> . — Reply to this email directly, view it on GitHub <#324 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABG66HPQ4H45RJ7FOIW6OL2FUFHJAVCNFSM6AAAAABTUFTYOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTGQ2TCMJRGU> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[anhnk]

Thanks for the prompt response! I've created a PR.

Looking forward to pulling the latest version. Kaffy has been saving me lots of time. Huge kudos to the team!