-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New feature] resizing tiled windows (split ratio) #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tiled windows, but i stil have to consider the right user interface
…ze_{width,height} <DEGREE:int>
…ons of tiled windows
…te the container's space
…e containers are nested in a same tiling direction
Thank you so much for this amazing patch... Everything is implemented so perfectly 😸 😸 😸 I only spotted one (possible) glitch. Here's the steps to reproduce:
I think perhaps we can remove Thank you again for your hard work! Love this so much... |
aesophor
reviewed
Jul 8, 2020
aesophor
reviewed
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request is going to add some interfaces to make it possible to resize tiled windows with keys.
By this, the class
Tree::Node
will have new member variableratio_
which represents how long the window is to its parent node and we will be able to resize the windows by modifying itsratio_
.Concretely, this request adds following four new actions.
resize_width <int>
/resize_height <int>
Resize the focused window by adding a given integer argument (percentage) to its ratio. To shrink windows, use negative values for the argument.
These two actions can resize floating windows too, as the
float_resize_*
action does (so they could be replacements of them). In that case, it regards thefloat_resize_step
value in config but not the absolute value of the given argument.resize_set_ratio <int>
Resize the focused window to the ratio specified by a given integer argument (%) and distribute the remaining space to its sibling windows evenly. This action is intended to be used to apply preferred layouts quickly.
resize_reset_ratios
Resize the focused window and its sibling windows so that they will share their parent's space evenly.
This request also adds some example configurations using these new actions.
Please feel free to let me know if you have any questions.
Thank you!