Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AENSv2.pointee, AENSv2.name types #251

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Nov 14, 2023

depends on #258

closes #210

based on aeternity/aeternity#4056

AENSv2 in aesophia looks implemented in aeternity/aesophia#426.

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk requested a review from dincho November 14, 2023 19:27
@hanssv
Copy link
Member

hanssv commented Nov 14, 2023

There hasn't been any general demand for such a branch - but I had it locally - it is now pushed to aesophia_cli

@dincho
Copy link
Member

dincho commented Nov 15, 2023

To test it properly we need a version of aesophia_cli that supports AENSv2.

to be more specific, a released version after initial/draft tests :)

@dincho
Copy link
Member

dincho commented Nov 15, 2023

Thanks for the implementation @davidyuk it looks straight forward so far. Thanks to @hanssv for BC :)

@davidyuk
Copy link
Member Author

As I understand, bytes(x) have a mandatory prefix of two bytes (FateTag.OBJECT, FateTag.OTYPE_BYTES), but this prefix looks missing in case of decoding AENSv2.name value with DataPr. The first two bytes get lost because of

const [bytes, rest] = byteArraySerializer.deserializeStream(buffer.slice(2))

The issue aeternity/aesophia#498 looks related. I'm not sure how to proceed here.

@dincho
Copy link
Member

dincho commented Feb 5, 2024

#258 has been merged, feel free to rebase this PR to get it in as well

@dincho dincho merged commit 0530639 into master Feb 8, 2024
2 checks passed
@dincho dincho deleted the aens_v2 branch February 8, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Introduces new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AENSPointee from Ceres
3 participants