-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rethink & consolidate usage of BigInt / BigNumber throughout the SDK #1290
Comments
we should make a proposal how to proceed here. |
here the calldata-lib implementation: one important note here:
|
another library related to that which is included in the SDK right now: |
Some time before I was investigating the ability to implement a custom wrapper around bigint to represent ae coints, but this feature on TS side is missed microsoft/TypeScript#2361 |
Approximate roadmap (each step may be done separately):
I've touched on this topic in #1762 but it is too heavy for sdk@13 |
almost forgot about this one 😅 good to see it being tackled 👍 |
Optionally we can have a fancy way to define ae amounts
Also, may be useful to define something between |
That's the right way to go IMO |
known related issues / PRs:
BigNumber
as contract methods param? (TxBuilderHelper.getMinimumNameFee
) #1251we should maybe also consult with @dincho here.
The text was updated successfully, but these errors were encountered: